Skip to content

Conversation

@mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented Oct 4, 2025

Proposed in a forum thread for review

  • Names are chosen without Unicode characters
  • Test cases are are not covering all edges

Thanks for comments / corrections of wording and naming. The exercise name might be changed also.

Edit: f-puzzles.com have not updated their TLS certificate, that's why the link checker currently fails.

@mk-mxp mk-mxp requested review from keiravillekode and oxe-i October 5, 2025 07:21
@mk-mxp
Copy link
Contributor Author

mk-mxp commented Oct 6, 2025

@IsaacG @ErikSchierboom Who can merge this?

@IsaacG
Copy link
Member

IsaacG commented Oct 6, 2025

@IsaacG @ErikSchierboom Who can merge this?

I thought you would be able to merge it once it was approved. I can merge it.

@IsaacG IsaacG merged commit 4ed5a3c into exercism:main Oct 6, 2025
6 of 7 checks passed
@mk-mxp mk-mxp deleted the add-line-up branch October 6, 2025 12:15

- Numbers ending in 1 (except for 11) → `"st"`
- Numbers ending in 2 (except for 12) → `"nd"`
- Numbers ending in 3 (except for 13) → `"rd"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should have been (unless ending in 13) to allow for numbers like 913.

@BNAndras BNAndras mentioned this pull request Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants